Fix Oracle ALTER COLUMN syntax for Element identifiers - #196
Merged
Merged
Conversation
Oracle interprets Element as syntax in an unparenthesized MODIFY clause, blocking KCC migrations with ORA-00903 and ORA-01735. Use the column-list form for default removal and column changes. Add live regressions that preserve existing values and verify new rows no longer receive the removed default; both failed before the fix and pass afterward. Unit and SQLite suites pass 382 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oracle interprets the valid column name
Elementas syntax in an unparenthesizedALTER TABLE ... MODIFYclause. KCC COMMON migration 196 fails with ORA-00903 while removing its default, then ORA-01735 when changing its type.Use
MODIFY (...)for both default removal and column changes. Existing identifier quoting remains in place. Two live Oracle regression cases verify direct default removal and removal throughChangeColumn, preserving existing values and checking that subsequent inserts receive NULL.Validation: