Skip to content

Fix Oracle ALTER COLUMN syntax for Element identifiers - #196

Merged
jogibear9988 merged 1 commit into
masterfrom
codex/kcc-oracle-followup
Sep 23, 2026
Merged

jogibear9988 merged 1 commit into
masterfrom
codex/kcc-oracle-followup

Conversation

@jogibear9988

@jogibear9988 jogibear9988 commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Oracle interprets the valid column name Element as syntax in an unparenthesized ALTER TABLE ... MODIFY clause. KCC COMMON migration 196 fails with ORA-00903 while removing its default, then ORA-01735 when changing its type.

Use MODIFY (...) for both default removal and column changes. Existing identifier quoting remains in place. Two live Oracle regression cases verify direct default removal and removal through ChangeColumn, preserving existing values and checking that subsequent inserts receive NULL.

Validation:

  • Both new cases failed against master before the fix and pass afterward against the configured Oracle instance.
  • Local Unit and SQLite suites: 382 passed, zero failures or skips.
  • Oracle CI passed. All other database matrix jobs passed except Sybase, where nine cases failed creating databases because MODEL was in use; the complete-coverage job was consequently skipped.
  • KCC full Oracle migration chain (COMMON, VISU, MFCV2, WMS) plus two data-preservation regression cases: 3 passed. KCC also needs explicit Oracle index and LOB-conversion adaptations, kept in its separate repository.

Oracle interprets Element as syntax in an unparenthesized MODIFY clause, blocking KCC migrations with ORA-00903 and ORA-01735. Use the column-list form for default removal and column changes. Add live regressions that preserve existing values and verify new rows no longer receive the removed default; both failed before the fix and pass afterward. Unit and SQLite suites pass 382 tests.
Copilot AI lite review requested due to automatic review settings September 23, 2026 21:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@jogibear9988
jogibear9988 merged commit b9e1236 into master Sep 23, 2026
26 of 27 checks passed
@jogibear9988
jogibear9988 deleted the codex/kcc-oracle-followup branch September 23, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants