Match SQLite GUID defaults to parameter storage without converting legacy defaults - #188
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite GUID parameters are stored as blobs, but CLR Guid column defaults were rendered as text. A defaulted child key therefore failed foreign-key validation against an explicitly inserted parent with the same GUID, blocking KCC's tenant migration.
Render new Guid defaults using the same Guid.ToByteArray() representation as parameters. Preserve existing GUID default SQL as RawSql during metadata inspection so unrelated rebuilds retain legacy text values and defaults without silently changing storage classes. Existing mixed-format data still requires an explicit data migration.
Eight tests were added before the fix: six failed and two passed. All eight now pass across Microsoft.Data.Sqlite and System.Data.SQLite, covering empty/nonempty GUIDs, byte order, foreign keys, populated-table backfills, rebuilds, and legacy text defaults.
Validation: