Skip to content

Clean up provider parsing, CLI validation, and duplicate tests - #186

Merged
jogibear9988 merged 1 commit into
masterfrom
codex/repository-cleanup
Sep 22, 2026
Merged

jogibear9988 merged 1 commit into
masterfrom
codex/repository-cleanup

Conversation

@jogibear9988

Copy link
Copy Markdown
Member

Changes

Separate SQL Server, PostgreSQL, and Oracle default-value parsing from catalog reads and share numeric/binary conversions. Numeric SQL NULL defaults now remain null, malformed binary literals are rejected instead of truncated, and PostgreSQL numeric defaults no longer depend on the table name.

Split CLI options from command execution and validate arguments before loading assemblies or opening connections. Preserve exit codes and credential-safe error messages, and consolidate the driver mapping.

Also fix migration-name edge cases, culture-dependent type lookup, unexpanded type templates, and swallowed factory errors. Remove duplicated loader/type registration logic, unnecessary dialect reflection, dead fixtures, and repeated test cases. Route deliberate obsolete-API compatibility tests through a narrowly suppressed test helper; production warnings remain enabled.

Validation

  • Solution rebuild: passed (19 remaining production compatibility/complexity warnings).
  • Unit tests: 175 passed, zero skipped, including 53 catalog parser cases.
  • SQLite tests: 203 passed, zero skipped; two duplicate generic scenarios removed.
  • Whitespace check: passed with CRLF endings allowed.

Server-backed database suites were not run locally because Docker is unavailable; the full provider CI matrix is required before merging. See docs/code-cleanup-review.md for details and remaining cleanup areas.

Copilot AI lite review requested due to automatic review settings September 22, 2026 20:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@jogibear9988
jogibear9988 merged commit f9a9869 into master Sep 22, 2026
13 checks passed
@jogibear9988
jogibear9988 deleted the codex/repository-cleanup branch September 22, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants