Clean up provider parsing, CLI validation, and duplicate tests - #186
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Separate SQL Server, PostgreSQL, and Oracle default-value parsing from catalog reads and share numeric/binary conversions. Numeric SQL NULL defaults now remain null, malformed binary literals are rejected instead of truncated, and PostgreSQL numeric defaults no longer depend on the table name.
Split CLI options from command execution and validate arguments before loading assemblies or opening connections. Preserve exit codes and credential-safe error messages, and consolidate the driver mapping.
Also fix migration-name edge cases, culture-dependent type lookup, unexpanded type templates, and swallowed factory errors. Remove duplicated loader/type registration logic, unnecessary dialect reflection, dead fixtures, and repeated test cases. Route deliberate obsolete-API compatibility tests through a narrowly suppressed test helper; production warnings remain enabled.
Validation
Server-backed database suites were not run locally because Docker is unavailable; the full provider CI matrix is required before merging. See
docs/code-cleanup-review.mdfor details and remaining cleanup areas.