Fix remaining provider time, constraint and schema regressions - #185
Merged
Merged
Conversation
jogibear9988
marked this pull request as ready for review
September 22, 2026 20:13
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time-of-day values were conflated with intervals, and quoted constraint names and qualified table names still broke catalog lookup or removal.
This change separates
TimeOnly(DbType.Time) fromTimeSpan(MigratorDbType.Interval), fixes native and legacy time defaults/parameters, and adds negative multi-day interval regressions. PostgreSQL/Oracle use native intervals; SQL Server/SQLite/MySQL/MariaDB use signed ticks. Informix Time now uses DATETIME HOUR TO SECOND. The migration guide documents the input change and engine precision limits.It also fixes SQLite MATCH validation, escaped multipart identifiers, table-scoped constraint lookup/removal, and Oracle/SQL Server schema metadata. Unsupported SQLite MATCH modes fail before reconstruction changes data. ASE key names containing dots or apostrophes are explicitly rejected before DDL because the tested engine could create the punctuated name but could not remove its backing constraint. Spaced ASE constraint names have a passing create/inspect/drop regression.
Validation: full matrix run 35778092728 passed all 12 test jobs and the coverage gate at code commit
226c106: 809 passed, zero failures, zero skips. The subsequent commitf4329b3changes documentation only. Local unit/SQLite selection: 299 passed.Related: #33, #48, #54, #162. The audit also records the merged Oracle sequence ownership policy (#140). Schema support outside the covered operations still needs follow-up; this PR does not claim every provider operation is schema-aware. Issues #134 and #141 were verified against merged fixes, commented, and closed.