Skip to content

Don't ask to report an issue if the server process was killed externally #9721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dibarbet wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Don't ask to report an issue if the server process was killed externally #9721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b52b1d
Distinguish external SIGKILL termination from language server crashes
dibarbet Sep 1, 2026
cebd40e
Capture the exit signal instead of retaining the server process
dibarbet Sep 1, 2026
3011b5b
Capture the server exit signal once at launch
dibarbet Sep 1, 2026
4b44cc7
don't ask to report issue if the server process was externally killed
dibarbet Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion l10n/bundle.l10n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,9 @@
"Detected change in telemetry settings. These will not take effect until the language server is restarted, would you like to restart?": "Detected change in telemetry settings. These will not take effect until the language server is restarted, would you like to restart?",
"Go to output": "Go to output",
"Report Issue": "Report Issue",
"The C# language server has crashed. Restart extensions to re-enable C# functionality.": "The C# language server has crashed. Restart extensions to re-enable C# functionality.",
"Restart extensions": "Restart extensions",
"The C# language server was terminated externally. Restart extensions to re-enable C# functionality.": "The C# language server was terminated externally. Restart extensions to re-enable C# functionality.",
"The C# language server has crashed. Restart extensions to re-enable C# functionality.": "The C# language server has crashed. Restart extensions to re-enable C# functionality.",
"Restore {0}": "Restore {0}",
"Restore already in progress": "Restore already in progress",
"Select context": "Select context",
Expand Down
181 changes: 62 additions & 119 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
"rxjs": "6.6.7",
"semver": "7.5.4",
"vscode-html-languageservice": "^5.3.1",
"vscode-languageclient": "10.0.0-next.20",
"vscode-languageclient": "10.1.1",
"yauzl": "3.2.1"
},
"devDependencies": {
Expand Down Expand Up @@ -5780,4 +5780,4 @@
}
}
}
}
}
Loading
Loading