Skip to content

Use hash-based string table reservations #132932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awakecoding wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −5
Open

Use hash-based string table reservations #132932

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5eafec2
Use hash-based string table reservations
awakecoding Aug 29, 2026
3e1647a
Address string table review feedback
awakecoding Aug 30, 2026
d26a801
Mark string offset map readonly
awakecoding Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/coreclr/tools/Common/Compiler/ObjectWriter/StringTableBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,15 @@
using System.Diagnostics;
using System.IO;
using System.Text;
using System.Linq;
using Internal.Text;

namespace ILCompiler.ObjectWriter
{
internal class StringTableBuilder
{
private readonly MemoryStream _stream = new();
private readonly SortedSet<Utf8String> _reservedStrings = new();
private Dictionary<Utf8String, uint> _stringToOffset = new();
private readonly HashSet<Utf8String> _reservedStrings = new();
private readonly Dictionary<Utf8String, uint> _stringToOffset = new();

public void Write(Stream stream)
{
Expand All @@ -43,9 +42,18 @@ public void ReserveString(Utf8String text)

private void FlushReservedStrings()
{
Utf8String[] reservedStrings = _reservedStrings.ToArray();
if (_reservedStrings.Count == 0)
{
return;
}

Utf8String[] reservedStrings = new Utf8String[_reservedStrings.Count];
_reservedStrings.CopyTo(reservedStrings);

Comment thread
awakecoding marked this conversation as resolved.
// Establish a deterministic order before the in-place suffix sort.
Array.Sort(reservedStrings);

// Pre-sort the string based on their matching suffix
// Sort strings so matching suffixes are adjacent.
MultiKeySort(reservedStrings, 0);

// Add the strings to string table
Expand Down
Loading