[cDAC] Add single-file application dump tests

[max-charlamb]

Note

This PR was created with assistance from GitHub Copilot.

Summary

Adds single-file application dump tests to the cDAC dump test framework. Single-file apps bundle the runtime into one executable, which changes how modules appear in crash dumps -- this was previously untested.

Changes

New PublishModes dimension

PublishModes is a new per-debuggee property (default: Normal), orthogonal to the existing R2RModes (R2R/Jit). Debuggees opt in with:

<PublishModes>Normal;SingleFile</PublishModes>

This produces compound dump directory names: singlefile-r2r, singlefile-jit.

Module discovery fix

ClrMdDumpHost.FindContractDescriptorAddress() now has a two-pass scan: first checks known runtime module names (fast path), then falls back to scanning all modules for the DotNetRuntimeContractDescriptor export. This handles single-file bundles where coreclr is embedded in the apphost.

Initial debuggees

Three debuggees opt in as initial coverage:

• BasicThreads (Thread contract)
• StackWalk (StackWalk contract)
• TypeHierarchy (RuntimeTypeSystem contract)

CI integration

No pipeline YAML changes needed -- the existing BuildDebuggeesOnly and PrepareHelixPayload MSBuild targets automatically pick up single-file variants for opted-in debuggees. The build stage already includes host+packs which builds singlefilehost.

Validation

• Locally validated: single-file dump generated and ThreadCounts_AreNonNegative(config: local/singlefile-r2r) passed
• Uses locally-built singlefilehost via targetingpacks.targets (same mechanism as R2R tests)

[Copilot]

Pull request overview

This PR extends the cDAC dump test framework to cover single-file published debuggees by introducing a new publish-mode dimension (normal vs single-file), updating dump layout handling, and making contract-descriptor discovery resilient to single-file bundling module names.

Changes:

• Added PublishMode/compound directory naming to TestConfiguration + updated dump-path resolution in DumpTestBase.
• Updated MSBuild/Helix plumbing to build/copy/run single-file debuggees and to generate metadata/dumps in singlefile-{r2r|jit} directories.
• Made ClrMdDumpHost.FindContractDescriptorAddress() fall back to scanning all modules for DotNetRuntimeContractDescriptor.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/native/managed/cdac/tests/DumpTests/TestConfiguration.cs	Adds PublishMode and CompoundDirName for dump directory naming.
src/native/managed/cdac/tests/DumpTests/DumpTestBase.cs	Enumerates publish modes and uses compound dir names when locating dumps.
src/native/managed/cdac/tests/DumpTests/Microsoft.Diagnostics.DataContractReader.DumpTests.csproj	Extends debuggee metadata generation and Helix payload copying for single-file variants.
src/native/managed/cdac/tests/DumpTests/DumpTests.targets	Adds publish-mode cross-product and single-file publish/dump generation targets.
src/native/managed/cdac/tests/DumpTests/ClrMdDumpHost.cs	Adds a second-pass module scan for the contract descriptor export.
src/native/managed/cdac/tests/DumpTests/cdac-dump-helix.proj	Runs single-file debuggees directly when IsSingleFile=true.
src/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.props	Introduces default PublishModes property for debuggees.
src/native/managed/cdac/tests/DumpTests/Debuggees/Directory.Build.targets	Plumbs PublishModes through GetDumpTypes metadata.
src/native/managed/cdac/tests/DumpTests/Debuggees/BasicThreads/BasicThreads.csproj	Opts debuggee into Normal;SingleFile.
src/native/managed/cdac/tests/DumpTests/Debuggees/StackWalk/StackWalk.csproj	Opts debuggee into Normal;SingleFile.
src/native/managed/cdac/tests/DumpTests/Debuggees/TypeHierarchy/TypeHierarchy.csproj	Opts debuggee into Normal;SingleFile.

[github-actions]

Code Review: [cDAC] Add single-file application dump tests

Verdict: ✅ Approve

Summary

This PR adds single-file application dump test support to the cDAC dump test framework. It introduces a PublishModes dimension (orthogonal to R2RModes), fixes module discovery for single-file bundles via a two-pass scan, and wires up the full build/Helix pipeline for opted-in debuggees.

Assessment

The change is well-structured, follows existing patterns in the test infrastructure, and all previous review comments have been addressed (resolved). No new public API surface is introduced.

Findings

💡 suggestion — Minor inefficiency in two-pass module scan

File: ClrMdDumpHost.cs — FindContractDescriptorAddress()

The second pass scans all modules, including those already checked in the first pass (known runtime modules). You could skip modules that passed IsRuntimeModule in the second pass to avoid redundant GetExportSymbolAddress calls. However, since this is test infrastructure (not production hot path) and the module list is typically small, this is purely cosmetic.

💡 suggestion — GetPublishModes() always yields both modes

File: DumpTestBase.cs

GetPublishModes() unconditionally yields "singlefile" for all debuggees, even those without single-file dumps. These are gracefully skipped via SkipTestException, which is consistent with how GetR2RModes() works — but it does mean xUnit output will show many skipped tests. This is acceptable but worth noting for future test output clarity.

Positive observations

• Clean separation: PublishModes is orthogonal to R2RModes and DumpTypes
• Proper validation: <Error> elements for invalid publish mode values
• Correct Helix integration: chmod +x for Unix single-file executables, DOTNET_DbgEnableMiniDump properly inherited from pre-commands
• _GenerateSingleFileDump always publishes with R2R (matching the existing pattern where runtime behavior is toggled via DOTNET_ReadyToRun env var)
• Good documentation in comments and XML docs

---

Models contributing: claude-opus-4.6 (primary)

Generated by Code Review for issue #128781 · ● 5.3M · ◷

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.