[browser][CoreCLR] more Wasm.Build.Tests#128762
Draft
pavelsavara wants to merge 4 commits into
Draft
Conversation
Member
pavelsavara
commented
May 29, 2026
pavelsavara
commented
- applicationEnvironment
- LoadLazyAssemblyBeforeItIsNeeded
- AppSettingsTests
- appsettings
- applicationEnvironment - LoadLazyAssemblyBeforeItIsNeeded - AppSettingsTests
pavelsavara
added
arch-wasm
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR broadens CoreCLR browser/Wasm test coverage by enabling appsettings-related build tests and a lazy-loading test, while adding the loader support needed for appsettings files and application environment selection.
Changes:
- Adds
applicationEnvironmentmerge/default handling to the shared JavaScript loader config. - Adds CoreCLR loader logic to place matching
appsettings*.jsonfiles into the VFS. - Enables additional Wasm.Build.Tests scenarios for CoreCLR.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/native/libs/Common/JavaScript/loader/run.ts |
Adds appsettings files to VFS downloads based on the configured application environment. |
src/native/libs/Common/JavaScript/loader/config.ts |
Carries applicationEnvironment through config merging and defaults it to Production. |
src/mono/wasm/Wasm.Build.Tests/LazyLoadingTests.cs |
Allows the lazy-loading theory to run for CoreCLR as well as Mono. |
eng/testing/scenarios/BuildWasmAppsJobsListCoreCLR.txt |
Adds appsettings test classes to the CoreCLR Wasm build-test scenario list. |
Comment on lines
+129
to
+130
| // Add appsettings files to VFS for download | ||
| if (loaderConfig.appsettings) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.