refactor(streaming): remove unused implicit subscriber grain factory - #10322
Open
ReubenBond wants to merge 2 commits into
Open
refactor(streaming): remove unused implicit subscriber grain factory#10322ReubenBond wants to merge 2 commits into
ReubenBond wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Orleans streaming implicit pub-sub to remove an unused IInternalGrainFactory parameter from implicit subscriber lookup and threads that simplification through the pub-sub implementation and both silo/client provider runtimes, reducing unnecessary coupling.
Changes:
- Removed the unused grain factory parameter from
ImplicitStreamSubscriberTable.GetImplicitSubscribers. - Updated
ImplicitStreamPubSubto no longer store/require an internal grain factory. - Updated silo/client streaming provider runtimes to construct
ImplicitStreamPubSubwith only the subscriber table.
Show a summary per file
| File | Description |
|---|---|
| src/Orleans.Streaming/PubSub/ImplicitStreamSubscriberTable.cs | Removes the unused factory parameter from implicit subscriber lookup (and should align docs with the returned dictionary). |
| src/Orleans.Streaming/PubSub/ImplicitStreamPubSub.cs | Removes factory dependency and updates call sites to the simplified lookup method. |
| src/Orleans.Streaming/Providers/SiloStreamProviderRuntime.cs | Updates runtime wiring to construct ImplicitStreamPubSub without the internal grain factory. |
| src/Orleans.Streaming/Providers/ClientStreamingProviderRuntime.cs | Updates runtime wiring to construct ImplicitStreamPubSub without the internal grain factory. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 2
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ccadbbac-3066-4b68-aab0-135e7419f4d5
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ccadbbac-3066-4b68-aab0-135e7419f4d5
ReubenBond
force-pushed
the
refactor/implicit-stream-subscriber-factory
branch
from
August 5, 2026 13:11
d520ca5 to
9afae2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unused internal grain factory parameter from implicit stream subscriber lookup and its callers. The lookup already returns grain IDs directly, so retaining and threading the factory adds unnecessary coupling.
Microsoft Reviewers: Open in CodeFlow