test: stabilize stream reliability lifecycle waits - #10226
Draft
ReubenBond wants to merge 5 commits into
Draft
Conversation
Wait for cluster liveness and manifest stabilization after silo lifecycle changes, then verify producer and consumer grains are reachable before post-lifecycle sends. Use async condition waits for stream pub/sub and received-count checks so failures include the last observed counts and elapsed wait time. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add pay-for-use streaming diagnostic events for pulling agent lifecycle, queue receiver initialization, and local stream registration. Use silo-local diagnostic probes to wait for stream readiness and item delivery in StreamReliabilityTests, and add fake-time coverage for stream inactivity cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace remaining sleep-based synchronization in StreamReliabilityTests with lifecycle, manifest, provider-readiness, producer/subscription registration, and item-delivery diagnostic signals. Convert pub/sub and receive-count helpers to final assertions after explicit waits. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses flakiness in the SMS stream reliability lifecycle tests by making post-lifecycle readiness checks deterministic instead of relying on silo-count checks and fixed polling loops.
The change targets these tests:
UnitTests.Streaming.Reliability.StreamReliabilityTests.SMS_StreamRel_AllSilosRestartUnitTests.Streaming.Reliability.StreamReliabilityTests.SMS_StreamRel_AllSilosRestart_PubSubCountsUnitTests.Streaming.Reliability.StreamReliabilityTests.SMS_StreamRel_SiloDies_ConsumerUnitTests.Streaming.Reliability.StreamReliabilityTests.SMS_StreamRel_SiloDies_ProducerUnitTests.Streaming.Reliability.StreamReliabilityTests.SMS_StreamRel_SiloRestarts_ConsumerUnitTests.Streaming.Reliability.StreamReliabilityTests.SMS_StreamRel_SiloRestarts_ProducerIt also improves shared pub/sub count diagnostics used by related streaming tests.
The solution now:
Microsoft Reviewers: Open in CodeFlow