[release/11.0.1xx-preview3] Make CoreCLR the default runtime for debug builds.#25051
[release/11.0.1xx-preview3] Make CoreCLR the default runtime for debug builds.#25051rolfbjarne wants to merge 2 commits intorelease/11.0.1xx-preview3from
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the SDK defaults to make CoreCLR the default runtime for debug builds (instead of Mono), aligning debug behavior with the intended runtime selection.
Changes:
- Adds a new defaulting rule for
UseMonoRuntimeintended to switch debug builds to CoreCLR. - Keeps existing defaulting rules for macOS and NativeAOT unchanged.
| --> | ||
| <_UseNativeAot Condition="'$(PublishAot)' == 'true' And '$(_IsPublishing)' == 'true'">true</_UseNativeAot> | ||
|
|
||
| <UseMonoRuntime Condition=" '$(UseMonoRuntime)' == '' And '$(_BundlerDebug)' == 'true'">false</UseMonoRuntime> |
There was a problem hiding this comment.
The new default UseMonoRuntime condition depends on $(_BundlerDebug), but _BundlerDebug is only computed later in dotnet/targets/Xamarin.Shared.Sdk.targets (before importing Microsoft.NET.Sdk). Since this file is a .props imported earlier, $(_BundlerDebug) will typically still be empty here, so this condition won’t fire and debug builds will continue to default to Mono. Consider basing the default on $(Configuration) == 'Debug' (and/or $(MtouchDebug)/$(MmpDebug) if those are set early), or move the UseMonoRuntime defaulting logic to a location where _BundlerDebug is already defined (and ensure dependent property groups still evaluate as intended).
| <UseMonoRuntime Condition=" '$(UseMonoRuntime)' == '' And '$(_BundlerDebug)' == 'true'">false</UseMonoRuntime> | |
| <UseMonoRuntime Condition=" '$(UseMonoRuntime)' == '' And '$(Configuration)' == 'Debug'">false</UseMonoRuntime> |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #4db2099] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #4db2099] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #4db2099] Build passed (Build macOS tests) ✅Pipeline on Agent |
🔥 [CI Build #4db2099] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 11 tests failed, 150 tests passed. Failures❌ dotnettests tests (iOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (MacCatalyst)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ dotnettests tests (tvOS)1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ linker tests1 tests failed, 43 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (iOS)2 tests failed, 13 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (MacCatalyst)2 tests failed, 17 tests passed.Failed tests
Html Report (VSDrops) Download ❌ windows tests1 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Sequoia (15) tests1 tests failed, 4 tests passed.Failed tests
Html Report (VSDrops) Download ❌ Tests on macOS Tahoe (26) tests1 tests failed, 4 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
No description provided.