Improve the RelationshipConceptualNull exception message #37414
Merged
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR improves the RelationshipConceptualNull exception message to provide better guidance to developers when they encounter issues with required relationships being severed. The enhancement adds information about the DeleteOrphansTiming option for scenarios where dependent entities are being moved to a different principal, along with a documentation link.
Key Changes:
- Enhanced error messages to include guidance on
context.ChangeTracker.DeleteOrphansTimingsetting - Added documentation link to relationship management docs
- Corrected test database name for consistency
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/EFCore/Properties/CoreStrings.resx |
Updated both RelationshipConceptualNull and RelationshipConceptualNullSensitive error message strings with additional guidance |
src/EFCore/Properties/CoreStrings.Designer.cs |
Regenerated designer code reflecting the updated error messages from the .resx file |
test/EFCore.SqlServer.FunctionalTests/GraphUpdates/GraphUpdatesSqlServerClientNoActionTest.cs |
Renamed test database from "GraphClientNoActionUpdatesTest" to "GraphUpdatesClientNoActionTest" for consistency |
Files not reviewed (1)
- src/EFCore/Properties/CoreStrings.Designer.cs: Language not supported
AndriySvyryd
force-pushed
the
Issue37413
branch
from
4af2ba0 to
3cb7ce6
Compare
roji
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37413