Refactors loading cert in EntraMockResponsePlugin. Closes #1610 - #1612
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors EntraMockResponsePlugin to avoid resolving the root X509Certificate2 during plugin construction (which can fail early in startup), and instead resolves it when it’s actually needed while processing mock responses—addressing the startup crash reported in #1610.
Changes:
- Replace constructor injection of
X509Certificate2with injection ofIServiceProvider. - Resolve
X509Certificate2on-demand when generating the dynamic key id and certificate chain placeholders.
garrytrinder
approved these changes
Apr 14, 2026
garrytrinder
approved these changes
Apr 14, 2026
garrytrinder
left a comment
garrytrinder
left a comment
Collaborator
There was a problem hiding this comment.
Tested locally. Proxy starts cleanly with EntraMockResponsePlugin enabled (no more X509Certificate2 DI crash), and mock token responses are returned correctly. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors loading cert in EntraMockResponsePlugin. Closes #1610