Optimize MSGraph OpenApi specs caching based on e-tag - #1379
Merged
waldekmastykarz merged 18 commits intoSep 11, 2025
Merged
waldekmastykarz merged 18 commits into
waldekmastykarz merged 18 commits into
Conversation
bartizan
marked this pull request as ready for review
September 3, 2025 10:37
Collaborator
|
Cool! We'll review it asap |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the MSGraph OpenAPI specs caching mechanism by implementing e-tag based conditional HTTP requests to avoid unnecessary downloads when the remote specs haven't changed.
- Adds e-tag support to track remote file changes and avoid redundant downloads
- Refactors the database generation flow to handle cases where specs haven't changed
- Improves file handling and database transaction management
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
waldekmastykarz
approved these changes
Sep 11, 2025
waldekmastykarz
left a comment
waldekmastykarz
left a comment
Collaborator
There was a problem hiding this comment.
Very cool! I've done a few cosmetic fixes but it works like a charm.
waldekmastykarz
enabled auto-merge (squash)
September 11, 2025 05:40
0xced
reviewed
Sep 25, 2025
| } | ||
|
|
||
| private static string GetGraphOpenApiYamlFileName(string version) => $"graph-{version.Replace(".", "_", StringComparison.OrdinalIgnoreCase)}-openapi.yaml"; | ||
| private static bool IsModifiedToday(FileInfo fileInfo) => fileInfo.Exists && fileInfo.LastWriteTime.Date == DateTime.Now.Date; |
There was a problem hiding this comment.
Could probably use DateTime.Today instead of DateTime.Now.Date
Collaborator
There was a problem hiding this comment.
Good catch! Would you be willing to submit a PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1377