-
Notifications
You must be signed in to change notification settings - Fork 97
Update more places with respect to ref-valued properties and indexers #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jnm2
wants to merge
6
commits into
draft-v8
Choose a base branch
from
jnm2/ref_valued_props_more
base: draft-v8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6037679
Nameof may reference set-only property
jnm2 9b709ff
Update more places with respect to ref-valued properties and indexers
jnm2 8711cac
Fix typo
jnm2 a9ca38b
Add xrefs
jnm2 c5e410a
Review suggestion
jnm2 90ca572
Don't forget to actually assign when setting a ref-valued property or…
jnm2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added text equates to stating that it is an error to write to a read-only property unless it isn't a read-only property…
That doesn’t make sense.
A property is read-only if:
C# started with one kind of property and one kind of indexer, now it has two – ref properties and ref indexers which behave more like array indexing – which though they don’t have an indexer per se have an indexing operation whose return is classified as a variable aka. a variable reference just like ref properties and ref indexers.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, I will investigate getting rid of the terms read-only property and write-only property across the spec and see what that change would amount to. Since the newish
readonlymodifier may be applied to a property and it has an entirely different meaning (a property could be settable and still readonly), we would find it confusing to continue using the term read-only property to refer to what assignments are allowed.