Preserve LibGit2 lifetimes and serialize tests - #1497
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AArnott
enabled auto-merge
September 1, 2026 02:53
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 1, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AArnott
changed the title
AArnott
enabled auto-merge
September 1, 2026 03:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve LibGit2Sharp object lifetimes by materializing commit queries before returning them and snapshotting
VersionOraclecontext data at construction.This eliminates deferred native access after a
GitContexthas been disposed, a repository-local source of Linux/net10 access violations.Serializes this test assembly's collections as temporary containment for a remaining access violation in LibGit2Sharp's live
Commit.Parentspath. The upstream failure is tracked in libgit2/libgit2sharp#2192.Testing
dotnet test --project test\Nerdbank.GitVersioning.Tests\Nerdbank.GitVersioning.Tests.csproj -c Release --framework net10.0 -- --filter-not-trait "TestCategory=FailsInCloudTest"