Add regex support to remapping and attributes#615
Open
TareHimself wants to merge 2 commits intodotnet:mainfrom
Open
Add regex support to remapping and attributes#615TareHimself wants to merge 2 commits intodotnet:mainfrom
TareHimself wants to merge 2 commits intodotnet:mainfrom
Conversation
Member
|
Can you elaborate on the use case for this? What are you hitting that requires full regex support and where the existing basic wildcard support is not sufficient? Supporting arbitrary external regex inputs is potentially dangerous and not something I'm keen on doing. I'm happy to do limited additional extensions to the existing remapping feature, however. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #614
This PR does not include tests. I created it to determine if the repo will allow regex for
--remapand--with-attributes. regex support is opt-in using a separate--remap-regexand--with-attributes-regex,--remap-regexsupports string formatting. These are some examplesif allowed I will start working on tests and this can also be added to
--with-typeas--with-type-regex