Fix iterator macro parameter variable interpretation#47
Merged
BlakeASmith merged 5 commits intomainfrom Sep 8, 2025
Merged
Conversation
Co-authored-by: blakeinvictoria <blakeinvictoria@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: blakeinvictoria <blakeinvictoria@gmail.com>
Co-authored-by: blakeinvictoria <blakeinvictoria@gmail.com>
Add exclude_function_params to parse_positional_usages to prevent false positives. Update analyzer orders and add variable type extraction for macro processing. Co-authored-by: blakeinvictoria <blakeinvictoria@gmail.com>
Co-authored-by: blakeinvictoria <blakeinvictoria@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude function parameters from CLI argument generation when used within functions targeted by iterator macros.
This fixes a bug where function parameters (e.g.,
$1,$2) within functions called by iterator macros were incorrectly identified as required CLI arguments. The macro's generated loop provides these parameters, so this change prevents the generation of unnecessary CLI arguments like--1or--2.