Fix default value parsing in argument comments#46
Merged
BlakeASmith merged 1 commit intomainfrom Sep 8, 2025
Merged
Conversation
Co-authored-by: blakeinvictoria <blakeinvictoria@gmail.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix parsing of default values in Google-style argument comments to correctly detect defaults in various edge cases.
The previous regex-based parsing had issues with descriptions ending with a period when no default was present, empty default value declarations (e.g.,
Default:), and incorrectly matching across multiple lines, leading to truncated or contaminated default values. The new approach processes comments line-by-line with more precise regex patterns to address these issues.