-
Notifications
You must be signed in to change notification settings - Fork 0
fix(psmux): IP/VPN pill renders blank — split text and colour into two options #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+27
−3
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct that the default is overwritten on reload — that tradeoff is deliberate, and the format-time fallback is the right eventual shape but not yet safe to adopt here:
#[fg=#{?@vpn_fg,#{@vpn_fg},#9ece6a}]needs psmux to support a truthiness conditional on a user option (#{?@vpn_fg,…}). Thisconfonly documents what was actually probed on psmux 3.3.7 (status 2/status-format[1]/centre/monitor-*/bg=default), and option-truthiness isn't on that list. After the monitor-bell regression (a CLI probe passed but the parser rejected the option), the bar's policy is to not put an unverified construct on the render path.So I'm keeping the known-safe
set -g @vpn_fgdefault for now. Once#{?@user_option,…}is confirmed on this psmux build, switching to the format-time fallback (dropping the default entirely) is a clean one-line follow-up.Generated by Claude Code