fix: caching integration test never exercised cache code path#2
fix: caching integration test never exercised cache code path#2nicholasadamou merged 1 commit intomasterfrom
Conversation
The caching test was running from the repo root where local scripts/ exist, causing source_file_from_utilities to always find local files and return before reaching the caching logic. The cache directory was never created, failing the test. Fix: copy only utilities.sh to a temp dir (no scripts/ alongside it) so the remote download + caching code path is exercised.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
The caching test was always running from the repo root where `scripts/` exists locally, so `source_file_from_utilities` found local files and returned before reaching the caching logic. The cache directory was never created, causing the test to fail.
Fix: Copy only `utilities.sh` to an isolated temp dir (no `scripts/` alongside it) so the remote download + caching code path is actually exercised.
Verified locally — all 6 tests pass.