Conversation
…for correct shared/circular reference checking
…Enumerable exclusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When comparing object graphs containing shared or circular references, the constraint silently skipped (
continue) any property whose expected value had been seen before. This meant structural identity — e.g. two properties on the expected object pointing to the same instance — was never verified against the actual graph.Changes
ComparisonContext(new)ReferenceComparer)EnterMatch/ExitMatchdepth tracking to reset bindings betweenApplyTocallsBackReferenceConstraint(new, inner class)continueskip when a previously-registered expected object is encountered againReferenceEquals(actual, previouslyBoundActual)— the same expected reference must correspond to the same actual referenceObjectPropertiesEqualsConstraintInitializeProperties: on back-reference, createsBackReferenceConstraintinstead of skipping;IEnumerabletypes are still delegated toEnumerableEqualsConstraint(no ref-tracking needed)Matches: callsEnterMatch/ExitMatcharound traversal; binds each forward-reference node's actual value viaBindActualComparisonContextflows through nested constraints (replacing the oldHashSet<object>)ReferenceComparerGetHashCodeto useRuntimeHelpers.GetHashCode(identity hash) instead ofobj.GetHashCode(), which could be overriddenTests