Repository navigation
Conversation
Remove the blanket E0764 execution gate and implement checked accessors, automatic backing fields, exact typed setters, borrowed results, and interface/trait/override dispatch through the shared compiler pipeline. Run parent then child declaration initializers over one backing slot. Acquire replacements before release and clean only initialized fields and completed ancestor phases on constructor failure. Remove false shared-handle return-borrow and readonly collection-read rejections. Distinguish owned result carriers from retained source loans, keep repeatable captures until environment destruction, and remove spurious ambient I/O effects only when callback provenance proves the actual effects. Reject genuinely blocking/async hook work transitively, including output. Isolate emitted PHP nominal type names from host reserved names and case folding; preserve its existing numeric compatibility diagnostics. Add public-pipeline, malformed-MIR, durable parity, and ownership regressions; update authority, API guidance, tooling facts, and CI coverage.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Replace the stale inline shared-property source check with the shared type contract and require its readonly, ownership, and availability regressions. Run the same documentation authority suite locally and in CI. Remove duplicate CI invocations without removing coverage, and run authority and diagnostic checks before canonical compiler builds. No language behavior is removed. Validation: all authority and diagnostic guards pass, the canonical LLVM plan includes them, and five focused shared-property regressions pass. Invalidated elsewhere: local validation now includes the previously CI-only authority checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement Stage 36 property hooks under Decision 0135 through the checked compiler pipeline.
writable get,borrowed get, typed setter inputs, and checked effects.Removed Or Corrected Boundaries
Validation
php scripts/validate_work_unit.php --llvm: passed on macOS ARM64, including formatting, both Clippy configurations, production builds, workspace tests, and LLVM suites.Invalidated Elsewhere
Language-server traversal, highlighting, hover, navigation, receiver/accessor facts, diagnostics, and compiler pin require the coordinated Stage 36 update. Website guides, API reference, tutorials, and playground examples must retain the accepted target-state contracts. Companion integration and installed-toolchain refresh are still pending; this PR does not yet claim overall Stage 36 closure.