Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70cb1de5c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves cross-platform compatibility and correctness, especially on Windows, and enhances the reliability of integer handling in runtime outcome decoding. It introduces more robust detection of host architecture, improves process handling for Windows, and ensures portable decoding of 64-bit integers. The changes are covered by new and updated unit tests.
Cross-platform host detection and architecture handling:
PROCESSOR_ARCHITEW6432,PROCESSOR_ARCHITECTURE). This logic is now used in bothpackaging/php-runtime/build.phpandsrc/Toolchain/Platform.php. [1] [2] [3] [4]PlatformTestto verify correct architecture detection for various Windows scenarios.Process execution improvements on Windows:
RunCommand.php, using direct descriptor inheritance to avoid issues with Symfony's input handling and to ensure proper interactive input behavior. [1] [2]Portable 64-bit integer decoding and testing:
RuntimeOutcomeReaderto handle 64-bit signed and unsigned integers portably, avoiding reliance on platform-specificunpack('P')and ensuring correct behavior across platforms and integer boundaries.RuntimeOutcomeReaderTestto verify decoding of host integer boundaries and to use a portable method for packing 64-bit integers. [1] [2] [3] [4] [5] [6]