Repository navigation
Fix: Temporal orWhere() filtering accepts every model - #374
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
applyPhpConditions()initializes$passtotrue. For the first or subsequentORcondition it evaluates$pass || $result, which is always true. A temporal query such asModel::at($time)->orWhere('status', 'closed')->get()therefore returns all snapshots, including rows that do not satisfy the condition. More complexwhere(...)->orWhere(...)combinations also do not preserve normal SQL boolean semantics.This PR will fix this issue.