Repository navigation
Clearer errors for frozen services - #371
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearer errors for frozen services
Summary
The
ImmutableViolationExceptionmessages were out of date and, forclone, confusing. This PR fixes the wording so the message matches how frozen services work today and tells the developer what to do.The problems
Cannot mutate property $__clone on immutable service [...]. There is no property called$__clone, so the message pointed the reader in the wrong direction.What changed
Mutation (write, dynamic property,
unset()):Clone:
ImmutableViolationExceptionchanged. Its constructor signature is the same, and the exception is thrown from the same places.testFreezeIsIdempotentnow callsfreeze()twice for real. It had the second call commented out, from beforefreeze()was safe to repeat.