Repository navigation
Drop pre-8.5 PDO MySQL constant fallbacks and tidy migrate:temporal output - #356
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
1. Remove PHP 8.3/8.4 MySQL constant fallbacks
composer.jsonalready requiresphp ^8.5, and PHP 8.5 deprecatesPDO::MYSQL_ATTR_*in favour ofPdo\Mysql::ATTR_*. The compatibility code for older PHP versions was therefore dead.MySQLDriver: removed themysqlAttr()helper.connect()now usesPdo\Mysql::ATTR_SSL_CA,ATTR_SSL_VERIFY_SERVER_CERT,ATTR_SSL_CERT,ATTR_SSL_KEY,ATTR_SSL_CAPATH,ATTR_SSL_CIPHERandATTR_INIT_COMMANDdirectly. Behaviour is unchanged: SSL options are applied only when a CA is configured, and server-cert verification is still disabled in that case.InteractsWithBigDataProcessing::openCursor(): removed the legacyPDO::MYSQL_ATTR_USE_BUFFERED_QUERYbranch. Thedefined('Pdo\Mysql::...')guard is kept on purpose, becausepdo_mysqlmay not be loaded on SQLite or PostgreSQL apps.Config note: the
mysqlconnection'soptionscan now be written as:Apps that still key
optionsbyPDO::MYSQL_ATTR_SSL_CAwill stop getting SSL options applied. The option is read from thePdo\Mysql::ATTR_*key only.2. Cleaner
migrate:temporaloutputEach model used to print five lines. It now prints one aligned line: status icon, model,
base → historytable, connection and status.✓for created or actor column added, yellow•for already exists, yellow›for would create (--show).--showstill prints the SQL, indented under each model line, and the header marks it as a dry run.Checklist