Add code review and test results#20
Draft
donvito wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Melvin Vivas <melvindave@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
review-results/code-review-and-test-results.mddocumenting code review findings.Testing
go version && go test ./...from/workspace(fails: no root Go module)go testfrom/workspace/testing(fails in module mode: no root Go module)go testfrom/workspace/benchmark(fails in module mode: no root Go module)GO111MODULE=off go testfrom/workspace/testing(passes)GO111MODULE=off go testfrom/workspace/benchmark(passes; no tests to run)go test ./...from/workspace/http-server(passes; no test files)go test ./...from/workspace/htmx(passes; no test files)go test ./...from/workspace/ai/go-groq(passes; no test files)go test ./...from/workspace/connect-to-db-postgres(passes; no test files)GO111MODULE=off go test ./...from/workspace(fails: external deps unavailable in GOPATH mode)git diff --check