Repository navigation
ci: compile the semgrep requirements, so Dependabot proposes sets pip can install - #188
Merged
Merged
Conversation
… can install Dependabot raised every line of .github/requirements-semgrep.txt on its own, past what semgrep allows: #184 moved 21 packages, boltons to 26.2.0 among them, while semgrep 1.180.0 asks for boltons~=21.0, and pip refused the whole set. Grouping kept them in one pull request but did not make them agree. semgrep is now pinned in requirements-semgrep.in, the one line a person writes, and the list beside it is compiled from it by pip-compile. An .in file in the directory makes Dependabot run pip-compile itself, so what it proposes is a set pip resolved. Compiled today with Python 3.14, pip 26.1.1 and pip-tools 7.5.3, the versions Dependabot runs, the list is the same 66 versions the freeze had - none of the 21 in #184 is inside what semgrep allows. Only the spelling of two names moves (ruamel.yaml as ruamel-yaml). The reasons that stood at the top of the list moved to the .in file, with the command that compiles it by hand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #184, which cannot be fixed in place.
Why #184 is red. Dependabot raised every line of
.github/requirements-semgrep.txton its own, past what semgrep allows. It moved 21 packages,boltonsto 26.2.0 among them, while semgrep 1.180.0 asks forboltons~=21.0, and pip refused the whole set (ResolutionImpossible). The group kept the lines in one pull request but did not make them agree, and it would happen again with the next major of any dependency.What changes
.github/requirements-semgrep.inholds the one line a person writes,semgrep==1.180.0, and the reasons that stood at the top of the list, with the command that compiles it by hand..github/requirements-semgrep.txtis compiled from it bypip-compile. An.infile in the directory makes Dependabot runpip-compileitself, so what it proposes is a set pip resolved.dependabot.ymlsays so next to the group.Checked
ruamel.yamlasruamel-yaml).semgrep --versionprints 1.180.0, andpip freezeof that install equals the compiled list.requirements-semgrep.txt, unchanged.Not checked: whether the dependency review job reads the
.infile as a manifest - this pull request's run shows it.🤖 Generated with Claude Code