W4 (part two): measure AUTO_CACHE and a held catalogue context, keep neither - #28
Merged
Merged
Conversation
…sured WTD_STATEACTION_AUTO_CACHE was prototyped against the product's catalogue path, file for file with identical verdicts, and rejected: no gain on one thread, and on several threads the calls queue behind a process-wide state, so the catalogue path took four times the wall clock at sixteen processors. A catalogue context held per worker saves about 1 ms per file on the first lookup, two or three percent of the pass on two processors, which is inside the pass's own spread. Comments only, no change in behaviour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The second part of W4 from the performance series: a prototype of
WTD_STATEACTION_AUTO_CACHEon the catalogue path of the signature check, measured before anything in the product changed.Result: rejected, and the product does not change behaviour. This PR only writes the measurement next to the code it is about, so the next outside review does not propose it again.
WinVerifyTrustis the same with and withoutAUTO_CACHE, within the spread, even with the files grouped by catalogue.Measured on 797 entries, 531 distinct files, 195 of them through 77 catalogues, with the verdicts compared file by file across every variant (no divergence).
Test plan
🤖 Generated with Claude Code