Skip to content

Enable replication tests on MacOS - #11359

Open
zachmu wants to merge 2 commits into
mainfrom
zachmu/replication-mac-os
Open

Enable replication tests on MacOS#11359
zachmu wants to merge 2 commits into
mainfrom
zachmu/replication-mac-os

Conversation

@zachmu

@zachmu zachmu commented Jul 28, 2026

Copy link
Copy Markdown
Member

DNS lookups on GitHub MacOS runners are very slow, which makes some of these test expectations fail. localhost resolves through DNS on MacOS but not on Ubuntu, which doesn't have this problem. This PR changes all localhost definitions in the test to the loopback address instead.

@coffeegoddd

Copy link
Copy Markdown
Contributor

@zachmu DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 2.35 2.35 0.0
groupby_scan 64.47 65.65 1.83
index_join 1.93 1.93 0.0
index_join_scan 1.32 1.32 0.0
index_scan 200.47 196.89 -1.79
oltp_point_select 0.25 0.26 4.0
oltp_read_only 5.09 5.09 0.0
select_random_points 0.54 0.55 1.85
select_random_ranges 0.68 0.69 1.47
table_scan 196.89 196.89 0.0
types_table_scan 458.96 450.77 -1.78
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.21 6.21 0.0
oltp_insert 3.13 3.13 0.0
oltp_read_write 11.45 11.45 0.0
oltp_update_index 3.3 3.3 0.0
oltp_update_non_index 3.02 3.02 0.0
oltp_write_only 6.32 6.32 0.0
types_delete_insert 6.91 6.91 0.0

@coffeegoddd

Copy link
Copy Markdown
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c45b5a3 ok 5937471
version total_tests
c45b5a3 5937471
correctness_percentage
100.0

@coffeegoddd

Copy link
Copy Markdown
Contributor

@zachmu DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 44.98 46.63 3.67
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt ad52ba4 52.81 dolt c45b5a3 52.79 -0.04

@reltuk

reltuk commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

I'm not sure I love the unconfigurable change to the global DNS resolution timeout. I'm not opposed to the s/localhost/127.*/ and enabling go-sql-server-driver on macOS though. It seems like these tests run just as quickly as on Linux, at least on this PR, which is quite surprising...

@zachmu zachmu changed the title Bug fixes for slow DNS lookups during replication Enable replication tests on MacOS Aug 3, 2026
@zachmu

zachmu commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

I'm not sure I love the unconfigurable change to the global DNS resolution timeout. I'm not opposed to the s/localhost/127.*/ and enabling go-sql-server-driver on macOS though. It seems like these tests run just as quickly as on Linux, at least on this PR, which is quite surprising...

For now I'll make this a test-only change. We can revisit the DNS timeout at a later date if it matters. The DNS timeouts seemed to mostly be an artifact of the GitHub runners, I could never repro on my own Macbook.

@reltuk reltuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants