Enable replication tests on MacOS - #11359
Conversation
…avoid localhost dns lookups in test config
|
@zachmu DOLT
|
|
I'm not sure I love the unconfigurable change to the global DNS resolution timeout. I'm not opposed to the s/localhost/127.*/ and enabling go-sql-server-driver on macOS though. It seems like these tests run just as quickly as on Linux, at least on this PR, which is quite surprising... |
For now I'll make this a test-only change. We can revisit the DNS timeout at a later date if it matters. The DNS timeouts seemed to mostly be an artifact of the GitHub runners, I could never repro on my own Macbook. |
DNS lookups on GitHub MacOS runners are very slow, which makes some of these test expectations fail.
localhostresolves through DNS on MacOS but not on Ubuntu, which doesn't have this problem. This PR changes alllocalhostdefinitions in the test to the loopback address instead.