Skip to content

Fix BIT value display in dolt sql and dolt diff -r sql - #11306

Open
elianddb wants to merge 6 commits into
mainfrom
elian/10132
Open

Fix BIT value display in dolt sql and dolt diff -r sql#11306
elianddb wants to merge 6 commits into
mainfrom
elian/10132

Conversation

@elianddb

@elianddb elianddb commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

BIT(n) values were printed as raw bytes, producing empty or corrupt SQL patches visually. BIT was also missing from the --binary-as-hex display path.

Note: The driver does not report declared BIT widths: display paths size hex output from the value bytes the server already pads to ceil(bits/8).

@elianddb
elianddb force-pushed the elian/10132 branch 2 times, most recently from c9aba24 to d4dc96b Compare July 15, 2026 23:26
@elianddb elianddb changed the title emit bit values as hex literals in sql output Fix BIT value display in dolt sql and dolt diff -r sql Jul 15, 2026
@coffeegoddd

coffeegoddd commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@elianddb DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 2.3 2.3 0.0
groupby_scan 144.97 147.61 1.82
index_join 1.93 1.93 0.0
index_join_scan 1.32 1.32 0.0
index_scan 215.44 219.36 1.82
oltp_point_select 0.26 0.25 -3.85
oltp_read_only 5.0 5.0 0.0
select_random_points 0.51 0.51 0.0
select_random_ranges 0.65 0.65 0.0
table_scan 204.11 207.82 1.82
types_table_scan 475.79 484.44 1.82
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.09 6.21 1.97
oltp_insert 3.13 3.13 0.0
oltp_read_write 11.24 11.24 0.0
oltp_update_index 3.3 3.3 0.0
oltp_update_non_index 3.02 2.97 -1.66
oltp_write_only 6.32 6.21 -1.74
types_delete_insert 6.79 6.79 0.0

@coffeegoddd

Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d4dc96b ok 5937471
version total_tests
d4dc96b 5937471
correctness_percentage
100.0

@coffeegoddd

coffeegoddd commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@elianddb DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 45.79 45.79 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 16fd54b 52.34 dolt 9430341 52.1 -0.46

@coffeegoddd

Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9430341 ok 5937471
version total_tests
9430341 5937471
correctness_percentage
100.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dolt diff -r sql doesn't show values for BIT(n) types

2 participants