Skip to content

Refactor SMS_EmitSinkInPollutionEffect vector normalization #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FranCarnovale wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −15
Open

Refactor SMS_EmitSinkInPollutionEffect vector normalization #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions src/MarioUtil/EffectUtil.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,32 +50,31 @@ void SMS_EmitSinkInPollutionEffect(const JGeometry::TVec3<float>& arg0,
{
if ((gpMarDirector->unk58 % 20) != 0)
return;

using namespace JGeometry;

const TVec3<f32> fwd(1.f, 0.0f, 0.0f);

TVec3<f32> B;
B.cross(fwd, arg1);

TPosition3f matrix;

TVec3<f32> C;
C.cross(arg1, B);
TVec3<f32> Cnorm;
Cnorm.normalize(C);
TVec3<f32> Bnorm;
Bnorm.normalize(B);

matrix.mMtx[0][0] = Cnorm.x;
matrix.mMtx[1][0] = Cnorm.y;
matrix.mMtx[2][0] = Cnorm.z;

C.normalize();
B.normalize();

TPosition3f matrix;

matrix.mMtx[0][0] = C.x;
matrix.mMtx[1][0] = C.y;
matrix.mMtx[2][0] = C.z;
matrix.mMtx[0][1] = arg1.x;
matrix.mMtx[1][1] = arg1.y;
matrix.mMtx[2][1] = arg1.z;
matrix.mMtx[0][2] = Bnorm.x;
matrix.mMtx[1][2] = Bnorm.y;
matrix.mMtx[2][2] = Bnorm.z;
matrix.mMtx[0][2] = B.x;
matrix.mMtx[1][2] = B.y;
matrix.mMtx[2][2] = B.z;
matrix.mMtx[0][3] = arg0.x;
matrix.mMtx[1][3] = arg0.y;
matrix.mMtx[2][3] = arg0.z;
Expand Down
Loading