Assert play scoping without a Dokku server - #430
Merged
josegonzalez merged 1 commit intoAug 7, 2026
Merged
Conversation
The seven play-scoping tests in `plays.bats` drove plain `plan`, which probes the server for every play that actually runs, so five of them failed rather than skipped on a machine without dokku. They now drive `plan --list-tasks`, which resolves play selection against the same merged context and returns before any task is planned, so the coverage stays available to contributors without Dokku instead of being gated away behind `require_dokku`. A new Go test pins that `plan` and `plan --list-tasks` agree on play selection, since the two resolve play `when:` in separate code paths.
josegonzalez
changed the title
josegonzalez
deleted the
412-plays-bats-play-scoping-tests-fail-without-dokku-instead-of-skipping
branch
August 7, 2026 18:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seven play-scoping tests in
plays.batsdrove plainplan, which probes the server for every play that actually runs, so five of them failed rather than skipped on a machine without dokku. They now driveplan --list-tasks, which resolves play selection against the same merged context and returns before any task is planned, so the coverage stays available to contributors without Dokku instead of being gated away behindrequire_dokku. A new Go test pins thatplanandplan --list-tasksagree on play selection, since the two resolve playwhen:in separate code paths.The full bats suite now runs clean with no
dokkuon$PATH: 216 pass, 0 fail.tests/bats/README.mdgains the gating convention that was previously only implied, so the next server-touching test does not repeat this.The dead
playWhenSkippedvariable noticed inrenderListTaskswhile working on this is left for #429.Fixes #412