fix: preserve free-form text in AutocompleteElement#403
Open
bethmaloney wants to merge 2 commits intodohomi:masterfrom
Open
fix: preserve free-form text in AutocompleteElement#403bethmaloney wants to merge 2 commits intodohomi:masterfrom
bethmaloney wants to merge 2 commits intodohomi:masterfrom
Conversation
…enabled The default input transform in AutocompleteElement always matches the value against the options list and returns null when no match is found, even when freeSolo is true. This causes user-typed free text to be discarded. Fall back to the raw value when freeSolo is enabled and no option match exists, for both single and multiple modes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add FreeSolo and FreeSoloMultiple stories to demonstrate and manually test free-form text input in the AutocompleteElement component. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@bethmaloney is attempting to deploy a commit to the Lumenmedia Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
freeSolotext (free text) was being discarded from the AutoComplete element.AutocompleteElementalways matches the form value against the options listmatchOptionByValue(), returningnullwhen no match is found even whenfreeSolois enabled. This causes user-typed free text to be silently discarded.freeSolois true, the transform now falls back to the raw value instead ofnull, for both single and multiple modes.Also added the free solo single/multi to storybook for testing