Use contrasting text color wherever custom background colors are used#369
Open
danielskeenan wants to merge 5 commits intodocsteer:masterfrom
Open
Use contrasting text color wherever custom background colors are used#369danielskeenan wants to merge 5 commits intodocsteer:masterfrom
danielskeenan wants to merge 5 commits intodocsteer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #368.
Change text color in
GridWidget,SACNSourceTableModel, andScopeModelwhenever the background color is set. I think these are the only places where a table cell gets a custom background color.There's a function in a new file
color_helpers.hcalledfindBestContrastingColor()that does the math, so if there are other places now or later it's simple enough to update. Not sure if this is the best place for that function, but I didn't want to tie it to the CID color calcs since it's useful elsewhere (like the scope window).Some screenshots: