feat: implement version checking for Docsify script URLs - #2799
Open
sy-records wants to merge 1 commit into
Open
feat: implement version checking for Docsify script URLs#2799sy-records wants to merge 1 commit into
sy-records wants to merge 1 commit into
Conversation
|
@sy-records is attempting to deploy a commit to the Docsify Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Warn users when Docsify is loaded from a URL that does not include a pinned version.
Unversioned CDN URLs may begin serving a future major release automatically, which can break existing documentation sites. Minor or patch releases may also introduce unexpected regressions.
When an unpinned Docsify URL is detected, Docsify now emits a single, prominent
console.errorcontaining the detected URL and guidance to pin a version.Supported URL formats
The version check recognizes:
docsify@5docsify@5.0docsify@5.0.0docsify@5.0.0-rc.1/docsify/5.0.0/docsify.js/docsify-5.0.0.js?v=5.0.0?version=5.0.0Known URL formats are supported for:
Self-hosted Docsify scripts are checked as well.
IIFE and ESM support
document.currentScript, with the existing<script>lookup as a fallback.import.meta.url.Example warning
The warning does not prevent Docsify from starting and is emitted at most once.
Testing
@latestValidation completed:
Related issue, if any:
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Tested in the following browsers: