Skip to content

ci: increase Testcontainers image pull timeout - #794

Merged
edeandrea merged 1 commit into
docling-project:mainfrom
edeandrea:ci/increase-testcontainers-pull-timeout
Nov 12, 2026
Merged

edeandrea merged 1 commit into
docling-project:mainfrom
edeandrea:ci/increase-testcontainers-pull-timeout

Conversation

@edeandrea

Copy link
Copy Markdown
Contributor

The prepare-test-reports jobs have been failing (e.g. on #776 and recent Dependabot PRs) with:

DoclingServeJackson2ClientTests > initializationError FAILED
  ContainerFetchException: Can't get Docker image: ghcr.io/docling-project/docling-serve:v1.35.0
    ConditionTimeoutException: ... RemoteDockerImage was not fulfilled within 2 minutes.

The docling-serve image pull was already close to Testcontainers' default 120s pull.timeout (1m57s in the last green main run) and now takes ~2m40s.

This sets TESTCONTAINERS_PULL_TIMEOUT=600 at the workflow level in build.yml.

Copilot AI balanced review requested due to automatic review settings November 12, 2026 15:06
The docling-serve image pull now regularly exceeds Testcontainers' default
120s pull timeout in the prepare-test-reports jobs, causing
DoclingServeJackson2ClientTests/DoclingServeJackson3ClientTests to fail with
ContainerFetchException. Raise the timeout to 600s for the build workflow.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Eric Deandrea <eric.deandrea@ibm.com>
@edeandrea
edeandrea force-pushed the ci/increase-testcontainers-pull-timeout branch from 6d4190d to 4da9356 Compare November 12, 2026 15:07
@edeandrea
edeandrea enabled auto-merge (squash) November 12, 2026 15:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the workflow image-pull timeout change.

No open issues 🎉

What changed in this PR

Increases the Testcontainers image pull timeout in the build workflow to accommodate slower downloads of the large Docling Serve image and prevent test initialization failures.

Changes:

  • Sets workflow-wide TESTCONTAINERS_PULL_TIMEOUT to 600 seconds, overriding the default 120 seconds.
  • Adds a comment explaining why the longer timeout is needed.
File Description
.github/​workflows/​build.yml Configures a 10-minute image pull timeout for all workflow jobs.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 12, 2026 15:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues with the CI image-pull timeout increase.

No open issues 🎉

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

:java_duke: JaCoCo coverage report

Overall Project 52.29% 🟢

There is no coverage information present for the Files changed

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
TestsPassed ✅SkippedFailed
Gradle Test Results (all modules & JDKs)2336 ran2336 passed0 skipped0 failed
TestResult
No test annotations available

@github-actions

Copy link
Copy Markdown

HTML test reports are available as workflow artifacts (zipped HTML).

• Download: Artifacts for this run

@edeandrea
edeandrea disabled auto-merge November 12, 2026 15:27
@edeandrea
edeandrea merged commit 8bc583a into docling-project:main Nov 12, 2026
28 checks passed
@github-actions

Copy link
Copy Markdown

HTML test reports are available as workflow artifacts (zipped HTML).

• Download: Artifacts for this run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants