Skip to content

Build workspace packages in the authoring image so validate-lab resolves them #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajeetraina wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Build workspace packages in the authoring image so validate-lab resolves them #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,12 @@ COPY app/packages/simulator/package.json ./packages/simulator/
COPY app/packages/labspace/package.json ./packages/labspace/
RUN npm ci
COPY app/ ./
# The workspace packages' `exports` point at compiled dist/ (gitignored). Vite
# aliases them to source (see vite.config.js), but validate-lab runs through a
# standalone esbuild (scripts/run-ts.mjs) with no such alias, so it resolves the
# real exports and needs dist/ to exist. Build the packages before the image is
# used, or `npm run validate-lab` fails with "Could not resolve
# @dockersamples/simspace-simulator".
RUN npm run build:packages
EXPOSE 5173
CMD ["npm", "run", "dev"]