Repository navigation
feat(skills): sync sbxenv authoring workflow into docker-sandboxes-env - #129
Closed
melmennaoui wants to merge 1 commit into
Closed
melmennaoui wants to merge 1 commit into
melmennaoui wants to merge 1 commit into
Conversation
Adapt docker/sandbox-kit-spec skills/sbxenv (75b2696a) into the existing docker-sandboxes-env owner instead of adding an overlapping skill: create/update workflow, live kit selection and pinning with the bundled scripts/kits.py helper (copied unchanged), and a full field reference. Refresh the guidance for sbx v0.51.0 and the published environment-files docs: --force replaces -y/--auto-approve, env exec offers interactive creation of a missing sandbox, user defaults, MCP command approval, recreate-on-change rules, adoption recovery, and per-command flags. Add offline tests for the helper's release ordering, pinning, and failure exits, and eval prompts for scaffolding, upgrading kits, and non-interactive exec. Bump the skill to 0.2.0. Signed-off-by: Mohamed EL MENNAOUI <mohamed.elmennaoui@docker.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the experimental
docker-sandboxes-envskill (0.1.0 → 0.2.0) by adaptingsbxenvfrom docker/sandbox-kit-spec at75b2696a.docker-sandboxes-envalready ownssbxenv.yaml, so this extends that skill instead of adding a second one for the same file.SKILL.md; the full procedure is inreferences/authoring-workflow.md.scripts/kits.py(copied unchanged; SHA-2561ca05d5f…): a live Docker Hub helper for searching kits, summarizing descriptors, upgrading by version order and pinning digests.-f/--forcereplaces-y/--auto-approve; it approves one run without recording consent.env execoffers to create a missing sandbox interactively, and fails non-interactively.~/.sbxenv.yamluser defaults, MCP command approval, which changes need a recreate, recovery after lost environment state, and per-command flags.references/env-schema-fields.mdnow covers every top-level field.rememberHostCommandscaution, and the destroy-plan recheck afterpreRemove.--force. New prompts cover scaffolding (8), upgrading kits (9) and non-interactiveexec(10). Prompt 9 has static checks against the helper.scripts/test_kits_helper.pycovers release ordering, the prerelease gate, update and pin behavior, local-source handling and failure exits. Breaking the version ordering or forcing exit 0 makes the tests fail.Why a minor bump:
ownsanduse_whengain kit selection and pinning insidesbxenv.yaml. That adds scope; existing routing doesn't change, and the sibling skills already sendsbxenv.yamlwork here. Maintainers may prefer a major bump.Verification
VERSION_CHECK_BASE_SHA=56001ac5… task: 250 unit tests OK; 270 eval checks pass, 0 fail, 23 skipped; version policy and DCO OK; links and verification scripts OK.search,describe,update,pin, plus missing-repository and connection-failure exits.sbx env planon the asset with sbx v0.51.0 and an isolated app name: the plan renders with the documented<agent>-<workspace-basename>name.Not verified / limitations
checks/verification.mdwere not run; they need a signed-in sbx and create sandboxes. Theenv execexit status 125 for a missing sandbox comes from the help text only.references/sources.md:.zipas local;7d55286d, which is internal; public readers can only verify claims against the docs and the help output.Follow-ups
docker-sandboxes-lifecycleanddocker-sandboxes-network-credentialsstill mention "kit spec.yaml" (v2 wording). They are not changed here.