Conversation
brianru
marked this pull request as ready for review
September 21, 2026 15:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
@actions/tool-cachefrom2.0.1to the bounded patch target2.0.2.Modernization only; no
@actions/tool-cacheCritical/High advisory target. This PR also regeneratesindex.js, the checked-in Rollup bundle executed by the GitHub Action.Evidence
modernization.@actions/tool-cache.dependency-plus-source; the only source-class path is the generated dependency assetindex.js.routine;src/index.jscallstool-cache.downloadToolwith an explicit destination, so the upstream replacement of internally generated UUID paths withcrypto.randomUUID()does not intersect the action's used path.@actions/core@1.11.1was already resolved through the action's direct dependency.index.js, rebuilt fromsrc/with the repository release valueVERSION=v1.24.0.docker/scout-action.action.yamland executed fromindex.js.repo-manifest.action.yaml->index.js->src/index.js->@actions/tool-cache.downloadTool.npm install @actions/tool-cache@^2.0.2 --package-lock-only --ignore-scripts --cache /tmp/deps-agent-test-lock; the repository npm configuration saves the direct target exactly as2.0.2and removes only its no-longer-needed transitiveuuidpackage.@actions/tool-cache;uuid@3.4.0is removed from the lockfile.npm audit --json --audit-level=highreported0 Critical / 1 High(the High is transitiveundicithrough the pre-existing direct@actions/coreand@actions/githubpaths); 6 total findings.0 Critical / 1 High, unchanged; 5 total findings after the Moderateuuidfinding is removed. The remaining High is outside this dependency family andnpm auditreports no compatible automatic fix.Release-Age Gate
External target
2.0.2was published2025-01-15T21:08:59.747Z, well over 72 hours ago.Usage Review
@actions/tool-cache@2.0.2removesuuidin favor of nativecrypto.randomUUID()for internally generated download and extraction paths, and updates its@actions/coredependency to1.11.1. I inspectedsrc/index.js, where the action callstc.downloadTool(asset.url, binary)with an explicit destination. The possible regression would be a failure to create or locate the downloaded Scout binary; that code path does not use the changed default temporary-path generation. No source or test change is needed.Validation
npm ci --ignore-scripts --cache /tmp/deps-agent-test-lock: passed for both the before and candidate locks.VERSION=v1.24.0 npm run build: passed; rerunning produced the sameindex.jsSHA-2562bb2d1270d66531f5436f37bf0d22a0a82523b129c98e45b9e6d82c35467a1ba.npm audit --json --audit-level=high: candidate remains0 Critical / 1 High; the High is the existing transitiveundicifinding.git diff --check: passed.npm testand lint commands are not declared. The repository's GitHub-hostedTestworkflow performs the action acceptance cases after a PR is opened.