Fix: allow tab auto-complete without executing#2325
Fix: allow tab auto-complete without executing#2325joshbarrington wants to merge 2 commits intodocker:mainfrom
Conversation
|
Thanks for referencing #2275 and building on it! I can see this version simplifies the implementation by moving the execute behavior into Update() directly and expands the tests as well. This looks like a cleaner approach to fix issues #2257 and #1819. I'm happy to defer to this implementation if maintainers prefer this direction. Looking forward to the review! |
|
Hey! Thanks for the contributions @joshbarrington && @yunus25jmi1 Both here and in #2275 we need to pay attention to not create regressions. As-is, this breaks the UX in other parts of the app. Auto-complete in it's current shape is not only used for With these changes:
We need to think about supporting both scenarios, so Not sure who wants to take on the changes, but we're glad to get changes merged as soon as they don't unintentially break other types of auto-complete :) Screencast below shows the problematic behavior: Screen.Recording.2026-04-04.at.21.37.24.mov |
|
@krissetto Thanks for the heads up on the regression. Are there any other inputs such as the '@' symbol that we need to be aware of? |
This fixes issues:
#2257
#1819
There was another implementation for a fix here: #2275
However I expanded upon that by simplifying and removing AutoComplete from the command interface, as this was hardcoded to be always true. It is now driven by the Update function directly.
I also added some more exhaustive tests and changes suggested through mise lint.