fix: pass Models map to RAG ManagersBuildConfig for model alias resolution#2324
Open
dgageot wants to merge 1 commit intodocker:mainfrom
Open
fix: pass Models map to RAG ManagersBuildConfig for model alias resolution#2324dgageot wants to merge 1 commit intodocker:mainfrom
dgageot wants to merge 1 commit intodocker:mainfrom
Conversation
…ution createRAGTool was not passing the Models map to rag.ManagersBuildConfig, causing RAG configs using model aliases for reranking to fail with 'model not found in configuration'. - Add Models field to config.Config - Populate runConfig.Models from cfg.Models in teamloader - Pass runConfig.Models through to ManagersBuildConfig in createRAGTool - Clone Models map in RuntimeConfig.Clone() to prevent shared state Assisted-By: docker-agent
krissetto
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
createRAGToolinpkg/teamloader/registry.gobuildsrag.ManagersBuildConfigwithout populating theModelsfield. This means any RAG config using a model alias for reranking (e.g.model: balancedreferencing a named model from the top-levelmodels:section) fails at runtime with:Fix
Modelsfield toconfig.ConfigrunConfig.Modelsfromcfg.Modelsin teamloader before agent loadingrunConfig.Modelsthrough toManagersBuildConfigincreateRAGToolModelsmap inRuntimeConfig.Clone()to prevent shared mutable state