Skip to content

buildflags: fix missing cache type error typo #3969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaJeztah merged 1 commit into from
Jul 23, 2026
+15 −2
Merged

buildflags: fix missing cache type error typo #3969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions util/buildflags/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ func (e *CacheOptionsEntry) UnmarshalText(text []byte) error {
}

if e.Type == "" {
return errors.Errorf("type required form> %q", in)
return errors.Errorf("type required for %q", in)
}
return e.validate(text)
}
Expand All @@ -132,7 +132,7 @@ func (e *CacheOptionsEntry) validate(gv any) error {
default:
text, _ = json.Marshal(gv)
}
return errors.Errorf("type required form> %q", string(text))

@thaJeztah thaJeztah Jul 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it wasn't meant to be <form>? 🤣

return errors.Errorf("type required for %q", string(text))
}
return nil
}
Expand Down
13 changes: 13 additions & 0 deletions util/buildflags/cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,3 +86,16 @@ func TestCacheOptions_RefOnlyFormat(t *testing.T) {
{Type: "registry", Attrs: map[string]string{"ref": "ref2"}},
}, opts)
}

func TestCacheOptions_MissingTypeError(t *testing.T) {
t.Run("ParseCacheEntry", func(t *testing.T) {
_, err := ParseCacheEntry([]string{"test=test"})
require.EqualError(t, err, `type required for "test=test"`)
})

t.Run("UnmarshalJSON", func(t *testing.T) {
var actual CacheOptionsEntry
err := json.Unmarshal([]byte(`{"ref":"user/app:cache"}`), &actual)
require.EqualError(t, err, `type required for "{\"ref\":\"user/app:cache\"}"`)
})
}
Loading