increase timeout for docker start#29
Open
better0fdead wants to merge 1 commit intodocker-practice:masterfrom
Open
increase timeout for docker start#29better0fdead wants to merge 1 commit intodocker-practice:masterfrom
better0fdead wants to merge 1 commit intodocker-practice:masterfrom
Conversation
Increased timeout for docker start from 180s to 600s. Have done it because sometimes 180s is not enough for github macOS runners.
better0fdead
force-pushed
the
better0fdead/increase-timeout
branch
from
a313c98 to
a657972
Compare
|
cc @00Kai0 @junchen1992 @khs1994 Would be nice to have this merged, I'm hitting the same issue. |
|
Please merge this, having same issue |
|
You can use this fix now with |
SaeedRe
added a commit
to Kynetics/hara-ddiclient-dev
that referenced
this pull request
Dec 27, 2023
The macOS build was failing time to time due to an issue described here: docker-practice/actions-setup-docker#29 This commit uses the fix provided in the github issue. Signed-off-by: Saeed Rezaee <saeed.rezaee@kynetics.it>
|
Many users would be happy with this merge 🙌🏼 |
This was referenced Jan 17, 2024
|
Probably even 300 would be enough. Often it takes just a bit more than 180 seconds: |
|
Very yes. |
|
ping @khs1994 , I see you merged some PRs recently. |
In my case, it takes 421s, so around 600 would be better. |
|
I've switched to https://github.com/douglascamata/setup-docker-macos-action because of this issue. Works good for me |
diegorondini
pushed a commit
to eclipse-hara/hara-ddiclient
that referenced
this pull request
May 21, 2024
Switch to a different action to install docker on Mac OS, the current one seems to be problematic. https://github.com/marketplace/actions/setup-docker-on-macos Useful references about the issue: actions/runner-images#17 docker-practice/actions-setup-docker#29 Signed-off-by: Diego Rondini <diego.rondini@kynetics.it>
diegorondini
pushed a commit
to eclipse-hara/hara-ddiclient
that referenced
this pull request
May 21, 2024
Switch to a different action to install docker on Mac OS, the current one seems to be problematic. https://github.com/marketplace/actions/setup-docker-on-macos Useful references about the issue: actions/runner-images#17 docker-practice/actions-setup-docker#29 Signed-off-by: Diego Rondini <diego.rondini@kynetics.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increased timeout for docker start from 180s to 600s.
Have done it because sometimes 180s is not enough for github macOs runners.
E.g run, run.