🔖 Release / v1.1.2#37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.1.2
Patch release covering the SAML nonce cookie fix landed in #36.
Fixed
ExSaml.AuthHandlernow resolves the nonce viaconn.assigns[:saml_nonce]first, falling back to the encryptedsaml_noncecookie and finally a freshUUID.uuid4/0. Becauseput_resp_cookie/4does not populatereq_cookies, the previous cookie-only lookup could not see a nonce the SP had just set on the same round-trip, so any auxiliary state (e.g.redirect_uri) persisted under that key failed to resolve when the IdP response came back (🐛 Fix / SAML nonce cookie #36).Changes in this PR
@versionto1.1.2inmix.exs[1.1.2]section and compare link toCHANGELOG.mdFull changelog: v1.1.1...v1.1.2