📝 Docs / Sync migration guide & changelog with 1.1.1 changes#34
Merged
Conversation
- Add flow: field to consume_signin_response/2 return shape in the Samly migration guide (matches the source @doc and 1.1.1 behaviour) - Add the missing [1.1.1] compare-link reference at the bottom of the changelog so the version heading is linked like the others
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bring the docs in line with the v1.1.1 changelog entries.
consume_signin_response/2's documented return shape was stale. Added theflow:field and a note on its values, matching the source@docand the actual 1.1.1 behaviour:[1.1.1]heading had no compare-link reference at the bottom (the list stopped at1.1.0), so the version heading wasn't linked like the others. Added the missing reference.Notes
doc/was also rebuilt locally (mix docs) to reflect 1.1.1 — theflow:field and the renamed:idp_initiated_not_allowedatom — butdoc/is gitignored, so it's not part of this PR.README.mdwas reviewed and left unchanged: none of the 1.1.1 changes touch its documented surface (the IdP-initiated flow is already listed as supported; the return shape and error atoms aren't documented there).