refactor(core): collapse SharedFrecency/SharedQueryTracker into generic SharedDb#617
Open
seuros wants to merge 2 commits into
Open
refactor(core): collapse SharedFrecency/SharedQueryTracker into generic SharedDb#617seuros wants to merge 2 commits into
seuros wants to merge 2 commits into
Conversation
SharedFrecency and SharedQueryTracker are now type aliases over a single SharedDb<T: LmdbStore>, and the three wait_for_* methods share one poll_until helper. Public API unchanged.
seuros
force-pushed
the
refactor/shared-db-generic
branch
from
58648cc to
81623ee
Compare
Owner
|
this is a hard breaking change - i don't think we want to make. They are exposed to the users of SDK and separate types to make users be able to choose if they want frecency, query tracking, or both. |
Owner
|
oh wait I actually read the code now lol this makes sense |
Author
|
Ahaha, i was going to reply : I can open similar PR while i'm reading/understanding the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SharedFrecency and SharedQueryTracker are now type aliases over a single SharedDb<T: LmdbStore>, and the three wait_for_* methods share one poll_until helper. Public API unchanged;
Sorry for the negative contribution :). -60 LOC