Skip to content

More random, more better #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KirosML merged 5 commits into from
May 18, 2026
Merged

More random, more better #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
52e2a11
More random, more better
KirosML May 18, 2026
6c25df9
dan zo
KirosML May 18, 2026
da18bc4
BAM
KirosML May 18, 2026
c0d36fe
x
KirosML May 18, 2026
93ca023
phpcs
KirosML May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/AbService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,10 @@ public function getVariant(string $experiment): string

public function getHash(string $uid, string $experiment): float
{
$hex = substr(hash('sha256', $uid . $experiment), 0, 16);
$hex = substr(hash('sha256', $uid . $experiment), 0, 15);
$int = hexdec($hex);

return $int / 0xFFFFFFFFFFFFFFFF;
return $int / 2 ** 60;
}

public function chooseVariant(float $hash, array $variants): string
Expand All @@ -122,8 +122,9 @@ public function chooseVariant(float $hash, array $variants): string

$names = array_keys($variants);
$weights = array_values($variants);
$nameCount = count($names);

for ($i = 0; $i < count($names) -1; $i++) {
for ($i = 0; $i < $nameCount - 1; $i++) {
$sum += $weights[$i];

if ($hash < $sum) {
Expand Down
2 changes: 1 addition & 1 deletion test/AbServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public function testGetVariant(): void
public function testGetVariantDistributed(): void
{
$this->markTestSkipped("takes a while");

$iterations = 1000000;
$delta = $iterations / 500; // 0.2% difference

Expand Down
Loading