Skip to content

Fix assertion failure on Windows when loading varlock #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theoephraim merged 4 commits into from
Feb 27, 2026
Merged

Fix assertion failure on Windows when loading varlock #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4475355
Initial plan
Copilot Jan 8, 2026
26a9bc6
Fix Windows assertion failure by removing duplicate gracefulExit call
Copilot Feb 24, 2026
0564095
Use alternative approach: remove gracefulExit from error branches ins…
Copilot Feb 24, 2026
061d298
Fix assertion failure on Windows for varlock cli
theoephraim Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/heavy-flies-move.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"varlock": patch
---

Fix assertion failure on Windows when varlock cli exits
2 changes: 0 additions & 2 deletions packages/varlock/src/cli/cli-executable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,11 @@ subCommands.set('telemetry', buildLazyCommand(telemetryCommandSpec, async () =>
suggestion: `Run \`${fmt.command('varlock --help', { jsPackageManager: true })}\` for more info.`,
});
console.error(badCommandErr.getFormattedOutput());
gracefulExit(1);
} else if (error instanceof CliExitError || error instanceof InvalidEnvError) {
// in watch mode, we just log but do not actually exit
console.error(error.getFormattedOutput());
// TODO: we'll probably want to implement watch mode, so it wont actually exit
// process.exit(1);
gracefulExit(1);
} else {
throw error;
}
Expand Down
Loading